tushman.io

The musings of an insecure technologist

How to Give Constructive Feedback to an Engineer

(I’ll give you a hint — it’s not down-voting, or one-liner emails)

tl;dr: Preface your constructive feedback with a compliment. And end the conversations with additional positive feedback. Make the negative feedback precise and timely

First, here is my FAVORITE clip of a boss giving his employee feedback

Everything you’re doing is bad, I want you to know this

We engineers, for whatever reason are a sensitive bunch. We are internally programmed to strive to get the acceptance of others. Whether its gaining cread on StackOverflow, Getting up voted on Reddit, or more frequently, trying to impress your boss and peers.

We can take it as fact that giving and receiving feedback is a Good Thing.

But if it is not presented well, it can have some unnecessary consequences. What we want to happen is have the person receiving the feedback, process it and hopefully take it to heart.

What we do not want to happen is to make the receiver get defensive or feel bad.

What works for me (and for others) is to wrap the constructive feedback with positive feedback. For example:

Jonathan, you clearly have been putting a lot of work into your blog. It has some really great ideas in here. I particularly liked your article about buying socks.

But, everything you are writing about has been written about already. Have you seen this New York Times Article about giving feedback — its pretty solid? I recommend doing a bit more research before posting

I do really enjoy your posts, and I look forward to reading more!

Just as important, is the timing of the feedback. Don’t wait until your quarterly review. If you have a way that a colleague could run a meeting better — tell her right afterwards. Try to build a culture of real-time feedback.

Now, this is not a silver bullet. I have also heard this approach called a “sh*t sandwich”. And if it is used too much — or without sincerity, it will not be effective. But, I think its a good arrow to put into your feedback quiver.

And just because this is a engineering blog …

feedback.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
from random import choice

beginning_affirmation = [
  "I like what you are doing here",
  "Nice use of a context manager, you should share that with the rest of the team",
  "I can not believe how much you have accomplished already"
]

ending_affirmation = [
  "Dude, I am pumped the direction this is heading",
  "Really good work",
  "Hey, lets grab lunch",
]

def constructive_feedback(feedback):
  return "{} but, {}. {}".format(choice(beginning_affirmation),feedback,choice(ending_affirmation))

# and so …

print constructive_feedback("More cowbell")

#yields: 'Nice use of a context manager, you should share that with the rest of the team but, More cowbell. Hey, lets grab lunch'

And dare I ask …. feedback?

Comments